Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #4263

Closed
wants to merge 1 commit into from
Closed

Fixed typo #4263

wants to merge 1 commit into from

Conversation

zebba
Copy link
Contributor

@zebba zebba commented Sep 23, 2014

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Sep 24, 2014

👍 Btw., this should be merged into the 2.3 branch.

@weaverryan
Copy link
Member

👍 @wouterj this looks like a good one to merge ;)

@wouterj
Copy link
Member

wouterj commented Sep 24, 2014

@weaverryan yeah, I couldn't get it working...

@wouterj
Copy link
Member

wouterj commented Sep 24, 2014

Great, thank you @zebba for allowing me to merge my first doc PR! :)

wouterj added a commit that referenced this pull request Sep 24, 2014
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4263).

Discussion
----------

Fixed typo

Commits
-------

23fdef3 Fixed typo
@xabbuh
Copy link
Member

xabbuh commented Sep 25, 2014

@wouterj Do we have to close the pull request manually when it was merged into another branch than it was submitted to?

@stof
Copy link
Member

stof commented Sep 25, 2014

@xabbuh either you close it manually, or you wait for the merge to be propagated until the master branch. Given that the merge commit contains closes #4263, it will close the PR automatically when it reaches the default branch (but not before)

@wouterj wouterj closed this Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants