Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: assets_version instead of asset_version #5058

Closed
wants to merge 2 commits into from
Closed

Fix: assets_version instead of asset_version #5058

wants to merge 2 commits into from

Conversation

sebastianblum
Copy link
Contributor

@javiereguiluz
Copy link
Member

@sebastianblum the reason for this issue is that the assets management has change a lot with the introduction of the new Asset component. We have the documentation for the component ready but it has to be merged: #4987

Once it's merged, we'll review all the doc to update the all the configuration options and code samples.

@stof
Copy link
Member

stof commented Mar 4, 2015

@javiereguiluz this change is actually right. asset_version does not exist in Symfony 2.6 (it is the new function introduced for the Asset component). In Symfony 2.6 and older, the function is assets_version (it still exist in 2.7 but it is deprecated)

@@ -113,12 +113,12 @@ Returns a public path to ``path``, which takes into account the base path set
for the package and the URL path. More information in
:ref:`book-templating-assets`. For asset versioning, see :ref:`ref-framework-assets-version`.

asset_version
assets_version
~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add one ~ here to match the new headline length.

@wouterj
Copy link
Member

wouterj commented Mar 25, 2015

@sebastianblum can you please add the missing tilde (~)? After that, this PR can be merged.

added the missing Tile
@sebastianblum
Copy link
Contributor Author

@wouterj sorry for the missing ~, now it should be fine.
Should I rebase the commit?

@wouterj
Copy link
Member

wouterj commented Mar 27, 2015

No, everything is perfect now. (I'm just waiting for GitHub to solve its ddos attack so I can merge...)

@wouterj
Copy link
Member

wouterj commented Mar 29, 2015

I finally managed to get through, thanks Sebastian!

wouterj added a commit that referenced this pull request Mar 29, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5058).

Discussion
----------

Fix: assets_version instead of asset_version

The name of the function is assets_version, see
https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/TwigBundle/Extension/AssetsExtension.php

Commits
-------

40363c9 Fix: assets_version instead of asset_version
@wouterj wouterj closed this Mar 29, 2015
@sebastianblum sebastianblum deleted the patch-2 branch March 30, 2015 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants