-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: assets_version instead of asset_version #5058
Conversation
The name of the function is assets_version, see https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/TwigBundle/Extension/AssetsExtension.php
@sebastianblum the reason for this issue is that the assets management has change a lot with the introduction of the new Asset component. We have the documentation for the component ready but it has to be merged: #4987 Once it's merged, we'll review all the doc to update the all the configuration options and code samples. |
@javiereguiluz this change is actually right. |
@@ -113,12 +113,12 @@ Returns a public path to ``path``, which takes into account the base path set | |||
for the package and the URL path. More information in | |||
:ref:`book-templating-assets`. For asset versioning, see :ref:`ref-framework-assets-version`. | |||
|
|||
asset_version | |||
assets_version | |||
~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add one ~ here to match the new headline length.
@sebastianblum can you please add the missing tilde ( |
added the missing Tile
@wouterj sorry for the missing ~, now it should be fine. |
No, everything is perfect now. (I'm just waiting for GitHub to solve its ddos attack so I can merge...) |
I finally managed to get through, thanks Sebastian! |
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5058). Discussion ---------- Fix: assets_version instead of asset_version The name of the function is assets_version, see https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/TwigBundle/Extension/AssetsExtension.php Commits ------- 40363c9 Fix: assets_version instead of asset_version
The name of the function is assets_version, see
https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/TwigBundle/Extension/AssetsExtension.php