Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppBundle #5819

Closed
wants to merge 1 commit into from
Closed

Remove AppBundle #5819

wants to merge 1 commit into from

Conversation

roukmoute
Copy link

The twig file is in app/Resources/views.
Fix error Unable to find template "AppBundle:Form:fields.html.twig"

@stof
Copy link
Member

stof commented Oct 21, 2015

Using the Form/fields.html.twig notation would be better, as this is what we use almost everywhere in the doc now

@stof
Copy link
Member

stof commented Oct 21, 2015

note that this notation can be used only for Twig, not for PHP templates

@wouterj
Copy link
Member

wouterj commented Oct 21, 2015

Actually, it should be form/fields.html.twig.

@roukmoute
Copy link
Author

@stof: I must keep this notation for code-block:: php or for the section For the PHP templating engine[...] ?

@stof
Copy link
Member

stof commented Oct 22, 2015

the PHP example needs to keep using the :Form notation yeah

@wouterj
Copy link
Member

wouterj commented Dec 17, 2015

@roukmoute can you please update the first 3 code blocks to use form/fields.html.twig and the other 3 to :form:fields.html.twig?

If you don't have time, feel free to say so and I'll finish this PR.

The twig file is in `app/Resources/views`.
Fix error `Unable to find template "AppBundle:Form:fields.html.twig"`
@roukmoute
Copy link
Author

Is it OK ?

wouterj added a commit that referenced this pull request Dec 19, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5819).

Discussion
----------

Remove AppBundle

The twig file is in `app/Resources/views`.
Fix error `Unable to find template "AppBundle:Form:fields.html.twig"`

Commits
-------

7b4a649 Remove AppBundle
@wouterj
Copy link
Member

wouterj commented Dec 19, 2015

Thank you for creating this PR & the patience with such a slow merge!

I've merged your PR into the 2.3 version of the docs (resulting in a closed status on GitHub) and will merge it into the newer versions from there. I've also changed the format a little bit (to not use the colon syntax for twig and reference PHP files in the second code example) in 4a41252.

Thanks again! 🎄

@wouterj wouterj closed this Dec 19, 2015
xabbuh added a commit that referenced this pull request Dec 19, 2015
@roukmoute roukmoute deleted the patch-1 branch December 19, 2015 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants