Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introduction.rst #6165

Closed
wants to merge 1 commit into from
Closed

Update introduction.rst #6165

wants to merge 1 commit into from

Conversation

martijn80
Copy link
Contributor

the docs are missing important info that the var_dumper component needs to added as a bundle to the appkernel

the docs are missing important info that the var_dumper component needs to added as a bundle to the appkernel
@@ -17,6 +17,9 @@ You can install the component in 2 different ways:
* :doc:`Install it via Composer </components/using_components>` (``symfony/var-dumper`` on `Packagist`_);
* Use the official Git repository (https://github.com/symfony/var-dumper).

.. note::
Make sure the bundle is added in your ``app/AppKernel.php``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be indented by four spaces.

@xabbuh
Copy link
Member

xabbuh commented Jan 19, 2016

Well, this section explains how to use the component outside of the full-stack framework. So there is no bundle to enable or something like that. Can you explain what issue you had that you think we should add something to the documentation? Maybe we can improve some other parts to make it easier to use the component.

@wouterj
Copy link
Member

wouterj commented Jan 20, 2016

@xabbuh the trouble here is that there are no bundle/cookbook articles about vardumper, only component docs. the component docs both explain DebugBundle and VarDumper component.

@xabbuh
Copy link
Member

xabbuh commented Jan 20, 2016

Oh, I didn't noticate that. Then we should fix that first imo.

@javiereguiluz
Copy link
Member

I propose to replace this by #6347 which tweaks the note contents a bit. I think this note is important while we prepare the documentation of VarDumper + Symfony.

@martijn80 I've reused your original commit so you get credit for your work. Thanks for this contribution!

@xabbuh
Copy link
Member

xabbuh commented Mar 11, 2016

Closing here in favour of #6347. Thank you very much for starting this @martijn80!

@xabbuh xabbuh closed this Mar 11, 2016
weaverryan added a commit that referenced this pull request Mar 17, 2016
…de Symfony (martijn80, javiereguiluz)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #6347).

Discussion
----------

Add a note about enabling DebugBundle to use VarDumper inside Symfony

This supersedes #6165 tweaking the proposed note contents.

Commits
-------

00bc64c Add a note about enabling DebugBundle to use VarDumper inside Symfony
2c79c08 Update introduction.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants