Warn on issue with controllers-as-services versus @Route annotation #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated without using the service-definition
DHager
changed the title
| @@ -76,6 +76,13 @@ Then you can define it as a service as follows: | |||
| 'AppBundle\Controller\HelloController' | |||
| )); | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| If you are managing your routes with PHP annotation, you may need to add an | |||
There was a problem hiding this comment.
It is not a may. It is always needed (otherwise the controller is not used as a service)
wouterj
added a commit
that referenced
this pull request
Jul 9, 2016
…n (DHager, WouterJ) This PR was merged into the 2.7 branch. Discussion ---------- Add little caution to add service id for @route annotation Finishes #6258 Original PR description: > I just ran into this problem and it took me a while. Without the `@Route(service="myid")` annotation, the controller was *always* being instantiated without any arguments, completely ignoring my service-definition. > Not sure how far back/forward this applies to other versions. Commits ------- 93bb21c Merge caution with annotations tip ac6b008 Add warning about a pitfall where the controller seems to be instantiated without using the service-definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into this problem and it took me a while. Without the
@Route(service="myid")annotation, the controller was always being instantiated without any arguments, completely ignoring my service-definition.Not sure how far back/forward this applies to other versions.