-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of handler channel configuration #6656
Conversation
See: https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/MonologExtension.php#L88 I believe this applies to all versions of Symfony, so should be merged into the branches of documentation for all of them.
Thank you for this suggestion @shkkmo. I think you are right with what you suggest. I just think we should maybe not embed it into this paragraph, but add it to its own |
Sure, didn't know where to added it, but it is definitely a gotcha that i
|
It will look like this: .. caution::
A handler that should log only messages for certain channels must be
a top-level handler. Handlers nested in filters, groups or other handlers
will receive every messages regardless of the channel. I think the best place would be just below the configuration block. |
@xabbuh Is this better? |
👍 Status: reviewed @shkkmo thanks for contributing this improvement. There are some very minor syntax issues in your pull request, but contributors can easily fix them when merging your work. Thanks! |
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6656). Discussion ---------- Clarify usage of handler channel configuration See: https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/MonologExtension.php#L88 I believe this applies to all versions of Symfony, so should be merged into the branches of documentation for all of them. Commits ------- 9b4d123 Clarify usage of handler channel configuration
* 2.7: (31 commits) Removing old :term: stuff Replacing missing link Fixing typo Final changes [WIP] More changes [WIP] More changes [WIP] Removing multiple formats - it makes no sense here [WIP] More changes [WIP] Reading through the changes changes according to comments after PR + some other typos typo fix in hyperlink typo fix in hyperlink colon corrections made some new changes, corrected mistakes, undo some foolish deletions [] changes in the first four ch of the book [#6656] Fix syntax to comply with docs standards Clarify usage of handler channel configuration replace occurrences of <?php echo with <?= Improve comment If context is defined, it is used instead of the firewall ...
See: https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/MonologExtension.php#L88
I believe this applies to all versions of Symfony, so should be merged into the branches of documentation for all of them.