-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update monolog.rst #6700
Update monolog.rst #6700
Conversation
Default value for buffer_size is unlimited, which worth being mentioned
according to https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Configuration.php default value is unlimited, not 30 |
looks like the XML example would need to be updated too |
@xabbuh I have updated xml as well |
👍 Status: reviewed @zhil a very nice catch in a very important document. We must be extra-careful in the configuration references to not make any mistake. |
Thanks @zhil! Fyi, I've merged this PR in the 2.7 version of the docs. I'll update the more recent versions from there. |
@wouterj @javiereguiluz @xabbuh should I create PR for it? |
@zhil I think that would be a good idea. Are you still interested in creating a PR? |
@xabbuh well, technically, its already documented IMHO "stop_buffering" is confusing term itself. If its set to true (default value) - finger_crossed in fact disabled after first error and everything after first error are placed in logs. Tthats correct approach for websites, but could be wrong for command line scripts. (If script do a lot of work in loops, it could create much more logs, as expected). I am not sure, where exactly should I add notice about it. Mayb short notice like "Please note, that by default fingers_crossed could create huge logs for command line scripts after first error" |
@zhil Is that the only place where we document that option? |
@xabbuh well, I suppose note could be also added ether in https://symfony.com/doc/current/logging/monolog_console.html or https://symfony.com/doc/current/logging.html |
@zhil Yeah, I think the former one is a must have, in the latter one we can probably omit it to not confuse the reader with too many details. |
Default value for buffer_size is unlimited, which worth being mentioned