[Components][Browser-Kit]Fix typo with CookieJar #6719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kieJar not Client
|
👍 Status: reviewed The Symfony API shows that this method belongs to the Client and not the Crawler: http://api.symfony.com/3.0/search.html?search=getCookieJar |
|
Thanks a lot of fixing incorrect code Denis! Fyi, I've merged this into the 2.7 docs (the oldest version we still maintain). I'll merge it into the more recent versions from there. |
wouterj
added a commit
that referenced
this pull request
Jul 8, 2016
…rin Rendler) This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6719). Discussion ---------- [Components][Browser-Kit]Fix typo with CookieJar Fix typo which mentions that the DomCrawler\Crawler, received from Client::request(), is exposing a method to retrieve the CookieJar instead of the Client implementation Commits ------- d556da7 [Components][Browser-Kit]Fix typo mentioning that Crawler exposes CookieJar not Client
|
That is great! |
|
@rendler-denis bug fixes will be merged in the oldest maintained branch affected by the bug (maintained branches are 2.7, 2.8, 3.0 and master currently). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo which mentions that the DomCrawler\Crawler, received from Client::request(), is exposing a method to retrieve the CookieJar instead of the Client implementation