Adjust Application use statement #6822
Conversation
The code example assumes the use of the Console Application (no kernel parameter) but the use statement is for the Frameworkbundle Console Application, which requires the kernel parameter. This is confusing, basically the example cannot work as it is.
|
After the code example there's this note:
Perhaps this note should be moved up, before the code example. |
|
@snoek09 That would be helpful but it doesn't change the fact that the sample itself is invalid. Either it needs to use the console application (as suggested in this PR) or it needs to provide a kernel parameter with the instantiation of the Application class. |
|
Fix looks fine to me. Thanks @kvdnberg 👍 Status: reviewed. |
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6822). Discussion ---------- Adjust Application use statement The code example assumes the use of the Console Application (no kernel parameter) but the use statement is for the Frameworkbundle Console Application, which requires the kernel parameter. This is confusing, basically the example cannot work as it is. Commits ------- 38d8f15 Adjust Application use statement
|
Hey Karin! This is great - you're absolutely right: the current code example just would not have worked as written. I've merged this PR (into the 2.7 branch) and also added some additional comments about how to do this in the framework at sha: f979387. If you see any issues, please let me know. Thanks! |
The code example assumes the use of the Console Application (no kernel parameter) but the use statement is for the Frameworkbundle Console Application, which requires the kernel parameter. This is confusing, basically the example cannot work as it is.