Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion failure message meaning #6916

Closed
wants to merge 1 commit into from
Closed

Fix assertion failure message meaning #6916

wants to merge 1 commit into from

Conversation

tanoabeleyra
Copy link

If the assertion fails it is because the "Content-Type" header is NOT "application/json"

If the assertion fails it is because the "Content-Type" header is NOT "application/json"
@snoek09
Copy link

snoek09 commented Aug 27, 2016

Thanks @tanoabeleyra.

I've looked into this and it seems this was done intentionally; #6736

Status: works for me.

@ogizanagi
Copy link
Contributor

ogizanagi commented Aug 27, 2016

I think it was totally intended: the assertion message should generally describe the test case it covers, not the reason it fails.

I.e: The the "Content-Type" header is "application/json" assertion failed.

See NullOutputTest for instance.

@tanoabeleyra
Copy link
Author

My apologies, I didn't know it was a common practice to write positive assert messages.

Thank you both for explaining it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants