Method "$this->getMock()" is deprecated #6925

JohnnyEvo · 2016-08-29T08:58:27Z

No description provided.

javiereguiluz · 2016-08-30T08:34:09Z

👍 getMock() is deprecated since PHPUnit 5.4.0. However, I wonder if we should use createMock() or getMockBuilder():

The PHPUnit\Framework\TestCase::getMock() method has been deprecated. Please use PHPUnit\Framework\TestCase::createMock() or PHPUnit\Framework\TestCase::getMockBuilder() instead.

Source: https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-5.4.0#changes

ogizanagi · 2016-08-30T09:14:43Z

👍 for using createMock()

ousmaneNdiaye · 2016-08-30T09:17:59Z

👍

JohnnyEvo · 2016-08-30T09:42:36Z

@ogizanagi Why use createMock() instead of getMockBuilder() ? I didn't know createMock() but createMock() doesn't invoke the constructor it seems to me, so it's possible that there are bad surprises.

ogizanagi · 2016-08-30T09:52:05Z

@JohnnyEvo : Right, but ObjectManager is an interface anyway. So using ->createMock() won't cause any issue. Also unless you do partial mocking on concrete classes, most of the time the original constructor call is not necessary.

JohnnyEvo · 2016-08-30T10:08:28Z

Ok, thank you for your explanation 👍

This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes #6925). Discussion ---------- Method "$this->getMock()" is deprecated Commits ------- e151754 Method "$this->getMock()" is depreciated

* 2.7: [#6925] Removing more instances of the deprecated getMock() Minor language tweaks removing cookbook entries updating links Moving files into the new structure [#6649] Changing a note to a caution - this *is* a gotcha fix typo Typo in the class name. Fixed indentation issues in alias_private article [Serializer] Document the encoders

weaverryan · 2016-09-18T23:40:46Z

Thanks guys! I've also updated a number of other getMock() usages at sha: c52839a

Cheers!

* 2.8: (32 commits) [#6925] Removing more instances of the deprecated getMock() Method "$this->getMock()" is depreciated Minor language tweaks removing cookbook entries updating links Moving files into the new structure [#6649] Changing a note to a caution - this *is* a gotcha fix typo Typo in the class name. Update tags.rst Fixed indentation issues in alias_private article Fix the error in code example [Controller Description] Remove backticks [Controller] Fix nested inline markup [Controller Description] Fix typos and class link Fix var_dumper advanced usage link [#6908] Add deprecations on some other places as well Add deprecation warnings to relevant profiler options Update access_control.rst DumpFile() third argument is deprecated and doesn't exists anymore in 3.x ...

* 3.0: [#6925] Removing more instances of the deprecated getMock() Method "$this->getMock()" is depreciated Minor language tweaks removing cookbook entries updating links Moving files into the new structure [#6649] Changing a note to a caution - this *is* a gotcha fix typo Typo in the class name. Update tags.rst Fixed indentation issues in alias_private article [Serializer] Document the encoders

Method "$this->getMock()" is depreciated

60276c6

carsonbot added the Status: Needs Review label Aug 29, 2016

javiereguiluz changed the title ~~Method "$this->getMock()" is depreciated~~ Method "$this->getMock()" is deprecated Aug 29, 2016

weaverryan added a commit that referenced this pull request Sep 18, 2016

[#6925] Removing more instances of the deprecated getMock()

c52839a

weaverryan closed this Sep 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Method "$this->getMock()" is deprecated #6925

Method "$this->getMock()" is deprecated #6925

JohnnyEvo commented Aug 29, 2016

javiereguiluz commented Aug 30, 2016

ogizanagi commented Aug 30, 2016

ousmaneNdiaye commented Aug 30, 2016

JohnnyEvo commented Aug 30, 2016

ogizanagi commented Aug 30, 2016 •

edited

Loading

JohnnyEvo commented Aug 30, 2016

weaverryan commented Sep 18, 2016

Method "$this->getMock()" is deprecated #6925

Method "$this->getMock()" is deprecated #6925

Conversation

JohnnyEvo commented Aug 29, 2016

javiereguiluz commented Aug 30, 2016

ogizanagi commented Aug 30, 2016

ousmaneNdiaye commented Aug 30, 2016

JohnnyEvo commented Aug 30, 2016

ogizanagi commented Aug 30, 2016 • edited Loading

JohnnyEvo commented Aug 30, 2016

weaverryan commented Sep 18, 2016

ogizanagi commented Aug 30, 2016 •

edited

Loading