Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize versionadded wording #7007

Merged
merged 1 commit into from
Sep 24, 2016
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 24, 2016

No description provided.

@@ -5,8 +5,8 @@ How to Define Non Shared Services
=================================

.. versionadded:: 2.8
The ``shared`` setting was introduced in Symfony 2.8. Prior to Symfony 2.8,
you had to use the ``prototype`` scope.
The ``shared`` options was introduced in Symfony 2.8. Prior to Symfony
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options -> option

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh force-pushed the normalize-versionadded branch from ee88df3 to 29e4241 Compare September 24, 2016 09:03
@wouterj wouterj merged commit 29e4241 into symfony:2.8 Sep 24, 2016
wouterj added a commit that referenced this pull request Sep 24, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

normalize versionadded wording

Commits
-------

29e4241 normalize versionadded wording
@xabbuh xabbuh deleted the normalize-versionadded branch September 24, 2016 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants