Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty parentheses to method names #7016

Closed
wants to merge 1 commit into from
Closed

Add empty parentheses to method names #7016

wants to merge 1 commit into from

Conversation

bocharsky-bw
Copy link
Contributor

@bocharsky-bw bocharsky-bw commented Sep 29, 2016 •
edited
Loading

Method name is clearer with empty parentheses at the end

xabbuh
xabbuh reviewed Sep 29, 2016
View reviewed changes
routing.rst
@@ -505,7 +505,7 @@ For example, a ``_controller`` value of ``AppBundle:Blog:show`` means:
============= ================== ==============
Bundle Controller Class Method Name
============= ================== ==============
``AppBundle`` ``BlogController`` ``showAction``
``AppBundle`` ``BlogController`` ``showAction()``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You now have to expand the table = lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, missed it. Expanded

@wouterj
Copy link
Member

wouterj commented Sep 29, 2016

👍
status: reviewed

Thanks!

@javiereguiluz
Copy link
Member

A big 👍 from me (and I think there are other places where we could do this change). Thanks @bocharsky-bw!

@wouterj
Copy link
Member

wouterj commented Sep 29, 2016

Thanks again! (fyi, this PR is closed as the commit has been merged in 2.7, the lowest still maintained branch)

wouterj added a commit that referenced this pull request Sep 29, 2016
@wouterj
minor #7016 Add empty parentheses to method names (bocharsky-bw)
50c8385 
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7016).

Discussion
----------

Add empty parentheses to method names

Method name is clearer with empty parentheses at the end

Commits
-------

04c44e9 Add empty parentheses to the method name
@wouterj wouterj closed this Sep 29, 2016
@bocharsky-bw
Copy link
Contributor Author

You're welcome!
@javiereguiluz I'll look closely at it and will send more PRs if I found something.
@wouterj Should I send further PRs to the 2.7 branch instead of master?

@bocharsky-bw bocharsky-bw deleted the patch-5 branch September 29, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bocharsky-bw @wouterj @javiereguiluz @xabbuh @carsonbot