Remove dash prefix from route name #7027
Conversation
Actually, in most cases, the `_` prefix means something internal and probably better to avoid using it in examples
|
AFAIK it's a naming convention. Status: needs work. |
|
Yes, it's a naming convention for something internal, e.g. framework routes, etc. But I think a user should avoid using it, shouldn't it? Could anyone provide a link where this naming convention are explained here in docs? |
|
I think @bocharsky-bw is right here. The leading |
|
A I personally also use the So indeed, 👍 for removing the underscore prefix. 👍 |
|
Why do we actually not use |
|
Good question! Actually, I don't see any prefixes in Symfony Best Practices for controllers. That's why I left this route name as simple as possible. |
|
@bocharsky-bw I agree with you. We never recommend to add prefix to route names. We do that because unlike services (where Symfony creates dozes of them) there are almost no built-in routes, so all/most of them belong to your application. |
|
Yet another nice PR, thanks Victor for your work! |
This PR was merged into the 2.7 branch. Discussion ---------- Remove dash prefix from route name Actually, in most cases, the `_` prefix means something internal and probably better to avoid using it in examples Commits ------- b547804 Remove dash prefix from route name
Actually, in most cases, the
_prefix means something internal and probably better to avoid using it in examples