[Security] [Firewall] Bug fixed in SimplePreAuthenticationListener when createToken() not return TokenInterface object #12002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
fabpot
force-pushed
the
security_bug_fixed
branch
from
f893d75 to
faa8e98
Compare
fabpot
added a commit
that referenced
this pull request
Sep 24, 2014
…Listener when createToken() not return TokenInterface object (adenkejawen, fabpot) This PR was merged into the 2.4 branch. Discussion ---------- [Security] [Firewall] Bug fixed in SimplePreAuthenticationListener when createToken() not return TokenInterface object | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #11490, #11414 | License | MIT | Doc PR | This is a follow-up for #11414 on the right branch. Commits ------- faa8e98 fixed bug e85cb7f added the possibility to return null from SimplePreAuthenticationListener
|
@fabpot I think symfony/symfony-docs#3815 could be closed as well hence returning null is now possible. |
|
@fabpot 👍 thanks |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 21, 2015
…null (xelaris) This PR was merged into the 2.5 branch. Discussion ---------- [Cookbook][Security] Hint about createToken can return null | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.5+ | Fixed tickets | see symfony/symfony#12002 Commits ------- 528aa17 [Cookbook][Security] Hint about createToken can return null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #11414 on the right branch.