[DependencyInjection] Fix "Cannot replace arguments" errors caused by ResolveAutowireInlineAttributesPass #54908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
May 13, 2024
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #54823 |
| License | MIT |
… ResolveAutowireInlineAttributesPass
nicolas-grekas
commented
May 13, 2024
| @@ -52,18 +52,13 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed | |||
| } | |||
| } | |||
|
|
|||
| $dummy = $value; | |||
| while (null === $dummy->getClass() && $dummy instanceof ChildDefinition) { | |||
There was a problem hiding this comment.
this is dead code: definitions with no class are already skipped before (and that's legit for child definitions too)
| @@ -89,19 +84,14 @@ private function registerAutowireInlineAttributes(\ReflectionFunctionAbstract $m | |||
| if ($method->isVariadic()) { | |||
| array_pop($parameters); | |||
| } | |||
| $dummyContainer = new ContainerBuilder($this->container->getParameterBag()); | |||
| $paramResolverContainer = new ContainerBuilder($this->container->getParameterBag()); | |||
|
|
|||
| foreach ($parameters as $index => $parameter) { | |||
| if ($isChildDefinition) { | |||
| $index = 'index_'.$index; | |||
There was a problem hiding this comment.
Renaming of indexes for child definitions is what caused the issue.
The patch fixes this using named arguments instead, which means using Definition::setArgument() instead of replaceArgument() when resolving child definitions.
GromNaN
approved these changes
May 13, 2024
derrabus
approved these changes
May 13, 2024
|
Thank you Nicolas for taking care of this regression. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.