Run tests for all supported versions defined for peerDependencies per component #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
run-vitest-all.sh
script to loop over every component/workspace and check if there arepeerDependencies
who defined support for multiple versions (like https://github.com/symfony/ux/blob/2.x/src/Svelte/assets/package.json#L23). The script then runs the tests for every defined version for that library in that workspace.The greatest benefit of this change is that this needs no extra administration in keeping a
matrix
value up-to-date in the GitHub workflow for every library in a workspace that supports more than 1 version as it checks everypackage.json
automatically.Tell me what you think about it! Cheers!
[email protected]
is installed[email protected]
is installed