-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs][LiveComponent] Add very simple download files docs #2513
base: 2.x
Are you sure you want to change the base?
Conversation
I'm not sure to understand the RST Linter failing. |
Hi, here some explanations:
For the |
Hi @Kocal and thanks. I don't want to pollute this PR with a non related topic but before fixing the
For testing purpose in order to see if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments on the code examples, and it should be good.
About the disparities between the local order and the CI, I don't really know, maybe the container version is different? Let's continue talking about this in a dedicated issue. Thanks 🙏🏻
Status: Needs Work |
Co-authored-by: Hugo Alliaume <[email protected]>
Co-authored-by: Simon André <[email protected]>
introduced with 99d3d21
Sorry for missing the unrelated modification introduced with the commit 99d3d21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The small note to remove and let's merge this! 😄
Co-authored-by: Simon André <[email protected]>
Motivated by #1516 (comment)
I don't know if it's enough.
Maybe a dedicated section about the behavior of turbo when a LiveAction of a Live Component is returning a
RedirectResponse
should be more appropriate ?