Autocomplete: Don't add plugins automaticly when defined

[maartendekeizer]

Q	A
Bug fix?	no
New feature?	no
Tickets	Fix #379
License	MIT

When plugins option is defined Symfony UX will no longer add some plugins by default. This make it possible to render a autocomplete without clear button extensions for example.

[weaverryan]

I like this approach - just one comment

[weaverryan]

Is this line right? That extra ! in front of this.tomSelectOptionsValue.plugins looks funny to me.

I'd love to have a test for this. It would live in https://github.com/symfony/ux/blob/2.x/src/Autocomplete/assets/test/controller.test.ts. In the existing pre-connect listener - https://github.com/symfony/ux/blob/2.x/src/Autocomplete/assets/test/controller.test.ts#L23 - we could add:

this.element.tomSelectOptions = event.detail.options;

Then, we could add a test that passes a data-autocomplete-tom-select-options-value="{ plugins: { virtual_scroll: {} } }" and verify with something like getByTestId(container, 'main-element').tomSelectOptions.plugins.toBe({ virtual_scroll: {} }).

[maartendekeizer]

@weaverryan Bit off topic but related to solving your feedback: Where can I find information about how to run tests cases etc. I think I am missing a good contribute to symfony/ux page. The part in the readme is very short and is also missing a part about building...

[weaverryan]

@maartendekeizer that's fair - that could certainly use some help :).

To run tests for a specific component, from the root of the project

yarn install
cd src/Autocomplete/assets
yarn jest

# or to run a specific test
yarn jest -t 'connect without options'

Let me know if that gives you any trouble - the tests can be tricky, but the existing ones in autocomplete should be fairly similar to what you're trying to do.

[weaverryan]

Friendly ping @maartendekeizer :)

[daFish]

Hey @maartendekeizer is there anything I can help with? 😄

[daFish]

@weaverryan How should we proceed with this PR?

[simonsolutions]

+1 for a solution for this problem. I'm facing it too and would like to have the PR procceded.

[simonsolutions]

I would vote for merging it to the next release please. We really need the fix.

[simonsolutions]

As the PR seems mergable without conflict, when can we expect this fix to be released?