Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EntrypointLookup "changeable" #2

Open
weaverryan opened this issue Oct 23, 2018 · 1 comment
Open

Make EntrypointLookup "changeable" #2

weaverryan opened this issue Oct 23, 2018 · 1 comment

Comments

@weaverryan
Copy link
Member

weaverryan commented Oct 23, 2018 •
edited
Loading

In some cases, you may want to use a different implementation of reading the entrypoint data (I've talked with someone about a use-case). So, we should:

  1. Create an interface for the lookup
  2. Add configuration so a new service can be "swapped" in
@codayblue codayblue mentioned this issue Oct 25, 2018
Merged
@weaverryan weaverryan changed the title Make EntrypointLookup and ManifestLookup "changeable" Make EntrypointLookup "changeable" Oct 29, 2018
@codayblue codayblue mentioned this issue Nov 3, 2018
Open
weaverryan added a commit that referenced this issue Nov 3, 2018
@weaverryan
feature #6 Create interfaces to make EntryLookup and ManifestLookup a…
ebe7747 
…re interchangable (codayblue, weaverryan)

This PR was merged into the master branch.

Discussion
----------

Create interfaces to make EntryLookup and ManifestLookup are interchangable

This will fix issue #2

This is a very simple change to create a set of interfaces to make parts of the bundle changeable by the user. With this change it makes the bundle more flexible because people can other developers can change the functionality to match what they need.

Commits
-------

9fabb2b Minor cleanup
99d890e Made the interfaces
@jkabat
Copy link

jkabat commented Nov 7, 2018

Ryan, first of all, thanks for the great package.
I'm not sure if this is the right place to bring it up, but since it relates to entrypoints, I'll ask here.

I'm using two different webpack configurations (something like symfony/webpack-encore#113 to give you an idea) and because one of them is located in subfolder, Im not able to use twig helpers to generate script and link tags for these entries.

Only the main entrypoints.json is found and used, not the one configured as different package under a subfolder.

My question is if I missed something in documentation or is it still not yet supported feature?

There also may be way to merge entrypoints files, but I'm too new to webpack to be aware of such possibility.

@richardhj richardhj mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverryan @jkabat