Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix EntrypointLookup Exception #111

Merged
merged 2 commits into from
Jun 6, 2021

Conversation

jeremyFreeAgent
Copy link
Contributor

Before it was:

Could not find the entry "fake_entry" in "...". Found: entrypoints.

@weaverryan
Copy link
Member

Thanks for this @jeremyFreeAgent!

We're getting a test failure with the lowest deps... expectExceptionMessageMatches is not defined, which is odd since that happens on PHPUnit 7.5.20, but that same version of PHP passes in another build on the matrix.

@jeremyFreeAgent
Copy link
Contributor Author

I didn't test it with that version in local. I'll look for it today to see why it is failing!

@jeremyFreeAgent
Copy link
Contributor Author

jeremyFreeAgent commented Feb 12, 2021

Work well with 7.3.26 and PHPUnit 7.5.20 in local. Very odd.

@jeremyFreeAgent
Copy link
Contributor Author

I reproduced the anomaly with installing dependencies as it is done in Travis (for 7.3 with low deps).
Maybe with symfony/phpunit-bridge (5.x-dev).

@weaverryan
Copy link
Member

Thanks for checking into this further! Could we bump phpunit-bridge to a higher version? I don't see any downside to that, as it's a dev-dependency anyways.

@jeremyFreeAgent
Copy link
Contributor Author

I'm going to try that!

@jeremyFreeAgent
Copy link
Contributor Author

@weaverryan what do you think?

@weaverryan
Copy link
Member

Thanks Jérémy! Sorry for letting this sit for so long :)

@weaverryan weaverryan merged commit 4188d41 into symfony:main Jun 6, 2021
@jeremyFreeAgent
Copy link
Contributor Author

Don’t worry! Happy to help ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants