Add encore_entry_exists() twig functions to check if entrypoint has files

[acrobat]

I've added 2 helper twig functions to check if the entrypoint exists and if it has files.

Closes #100

[weaverryan]

Hi!

Can you explain your use-case a bit more? If your entry doesn't have an CSS or JS files, they already won't be rendered. But perhaps you have some situation where an entrypoint may or may not be even defined (?) and you need to be able to have encore_entry_script_tags('foo') without generating an error that the entry doesn't exist?

Cheers!

[acrobat]

Hi @weaverryan,

Yes indeed the last part is our use case. We are in the progress of replacing a custom build layer (on top of webpack) with symfony encore in our Kunstmaan CMS. If you install the cms your project has 2 "setup's" an "app" entry (or even split in multiple smaller entries) for the frontend of the website and an "admin" entry which users can define (but are not required to) to override css/js of the admin interface.

The switch to symfony encore is almost ready, but we had indeed the issue that the call encore_entry_script_tags('admin') for the admin entry (which might not be defined in a user project) throws an exception.

webpack-encore-bundle/src/Asset/EntrypointLookup.php

Lines 95 to 102 in 5a86aad

	if (!isset($entriesData['entrypoints'][$entryName]) && $this->strictMode) {
	$withoutExtension = substr($entryName, 0, strrpos($entryName, '.'));
	if (isset($entriesData['entrypoints'][$withoutExtension])) {
	throw new EntrypointNotFoundException(sprintf('Could not find the entry "%s". Try "%s" instead (without the extension).', $entryName, $withoutExtension));
	}
	throw new EntrypointNotFoundException(sprintf('Could not find the entry "%s" in "%s". Found: %s.', $entryName, $this->entrypointJsonPath, implode(', ', array_keys($entriesData['entrypoints']))));

So that's the reasoning behind this PR, but as you suggested not throwing or catching the exception in encore_entry_script_tags and encore_entry_link_tags would also fix our case. I don't know which approach you prefer, but I'm able to update the PR if needed!

[weaverryan]

What about a single function: encore_entry_exists()? Because it is not about whether or not there are css or js files in this entry - just whether the entry is defined at all, right?

[acrobat]

that would work too! I will adjust the PR

[acrobat]

I've updated the code!

[Exellent1988]

is there any progress regaring the pull request? I'm also quite interested in this function to check if an tag has files / exists at all.

[acrobat]

@weaverryan I think this PR is ready for a final review, let me know if there are any changes needed!

[acrobat]

Friendly ping @weaverryan

[weaverryan]

Hmm. I don't love this part.

Instead, what if we add an entryExists() method to EntrypointLookup. It would NOT be part of the interface - but a bonus method on that class.

Then, in here, we would have something like:

$entrypointLookup = $this->getEntrypointLookup($entrypointName);
if (!$entrypointLookup instanceof EntrypointLookup) {
    throw new \LogicException(sprintf('Cannot use entryExists() unless the entrypoint lookup is an instance of "%s", EntrypointLookup::class));
}

return $entrypointLookup->entryExists($entryName);

This will avoid the "reset()" part, which could, in theory, have some side effects (if you have, somehow, already rendered some files from this entrypointlookup).

[acrobat]

Sounds like a good solution to me, I've updated the PR with the requested changes!

[weaverryan]

Thanks @acrobat!