Moving deprecated code handling for stimulus_ functions into Twig extension #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Jul 13, 2022
| */ | ||
| public function addAction($controllerName, string $actionName = null, string $eventName = null, array $parameters = []): void | ||
| public function addAction(string $controllerName, string $actionName, string $eventName = null, array $parameters = []): void |
There was a problem hiding this comment.
The addition of the string argument type (which i also added to the other Dto classes) is technically a BC break if you're using version 1.15.0 exactly. However, to have code that would trigger that break, you would have needed to start using these classes directly in 1.15.0 and pass the array argument... which would have triggered deprecations immediately (you don't see it here because it's already moved, but in 1.15.0 a deprecation is triggered in this method if you pass an array to $controllerName). So, I think it's not a problem.
weaverryan
commented
Jul 13, 2022
|
|
||
| $this->values['data-'.$controllerName.'-'.$key.'-value'] = $value; | ||
| } | ||
| $this->values['data-'.$controllerName.'-'.$key.'-value'] = $value; |
There was a problem hiding this comment.
All of this is covered by tests for controllers, actions and targets (I double-checked).
weaverryan
force-pushed
the
stricter_args_new_stimulus_functions
branch
from
ae90895 to
19ea5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This follows up on @jmsche continued work with the Stimulus functions. Basically:
A) The only deprecated should be in the Twig extension: we deprecated passing certain args as an array there. And so, the code to "normalize" the deprecated arguments should live there.
B) This allows the DTO classes to be "pure" classes that are not encumbered by any deprecation later.
Cheers!