Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing priority of pass to remove before Twig tries to use it #213

Merged
merged 1 commit into from
May 29, 2023

Conversation

weaverryan
Copy link
Member

Hi!

In 1.17.0, a compiler pass was added to remove the Twig extension that supplies the stimulus_ functions if StimulusBundle is installed (because it supplies those instead). However, the priority needs to be higher, else (depending on the order your bundles are installed) Twig might try to use the service first... and then we remove it. Results in:

The service "twig" has a dependency on a non-existent service "webpack_encore.twig_stimulus_
extension". Did you mean this: "webpack_encore.twig_entry_files_extension"?

Cheers!

@weaverryan weaverryan merged commit 7e3b6f6 into symfony:main May 29, 2023
@weaverryan weaverryan deleted the higher-priority-compiler-pass branch May 29, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant