-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 compatibility #98
Conversation
So, the tests pass, but Travis fails because of this deprecation:
However I can't find a way to get Twig Environment properly from the container, any idea about this? |
You can inject |
@maxhelias yes that's not really easy in fact, I'm already helping @jmsche on Symfony Slack and I think we will use the |
Finally Travis is green :) Many thanks to @Kocal who helped me a lot :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment - I think I might be missing a detail. Thanks for this - it looks great!
Updated PR by renaming test interface & fixing symfony/flex branch name in Travis config. Travis is green again! :) |
Thank you so much for this detailed work @jmsche! |
Tests are also run against PHP7.4.