Replace pkg-up
by an inlined solution
#1303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg-up
is deprecated, and has been replaced bypackage-up
. This one is more lightweight, but is only available as ESM format, which is not compatible with Encore.So, I've dropped
pkg-up
and inlinedpackage-up
and its single dependencyfind-up-simple
, with some tests.Removing
pkg-up
remove a lot of sub-dependencies aswell, which is better in term of security, but also in term of bandwidth and size on disk.Here, you can see the impact without
pkg-up
and withpackage-up
, we reduce the bandwidth consumption by ~500 GB (but note that our inlined solution is smaller thanpackage-up
):