Add tests for CSS Modules with React and Preact #1343
Conversation
Kocal
force-pushed
the
test-css-modules-frameworks
branch
from
0f7130e to
8f3aef2
Compare
| babelConfig.presets.push([require.resolve('@babel/preset-react'), { | ||
| // TODO: To remove when Babel 8, "automatic" will become the default value | ||
| runtime: 'automatic', | ||
| }]); |
There was a problem hiding this comment.
Quick-win, let's bump @babel/preset-react to ^7.9.0 to use runtime: 'automatic'
Kocal
force-pushed
the
test-css-modules-frameworks
branch
from
8f3aef2 to
a4450ee
Compare
| @@ -48,7 +48,7 @@ | |||
| "@babel/eslint-parser": "^7.17.0", | |||
| "@babel/plugin-transform-react-jsx": "^7.12.11", | |||
| "@babel/preset-env": "^7.16.0", | |||
| "@babel/preset-react": "^7.0.0", | |||
| "@babel/preset-react": "^7.9.0", | |||
There was a problem hiding this comment.
bumping the dev dependency alone is not enough. For our users, what matters for the package managers is the peerDependencies section.
btw, we should update our features utility to make it enforce versions based on peerDependencies rather than devDependencies now that we properly define peer dependencies. Or we should drop that runtime check entirely in favor of letting yarn/npm/pnpm show the warning at installation time.
There was a problem hiding this comment.
Oh yes, forgot about peerDeps, thanks
There was a problem hiding this comment.
btw, we should update our
featuresutility to make it enforce versions based onpeerDependenciesrather thandevDependenciesnow that we properly define peer dependencies. Or we should drop that runtime check entirely in favor of letting yarn/npm/pnpm show the warning at installation time.
Totally! Maybe we can do 1) for v5, and 2) for v6?
There was a problem hiding this comment.
the first change can even be done in a minor version (as that's about changing the internal implementation only). Our peerDependencies is already what package managers will report.
Kocal
force-pushed
the
test-css-modules-frameworks
branch
from
a4450ee to
c22943b
Compare
Quick PR to add functional tests about using CSS Modules with React and Preact, to see it it also break CSS Modules with them in #1319.