-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update various dependencies and remove the LoaderOptionsPlugin #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
update-dependencies
branch
from
March 16, 2019 12:10
a0f8e93
to
aeea89b
Compare
Great job and thanks for summarizing the important changes. I'll include in the release. |
weaverryan
added a commit
that referenced
this pull request
Mar 25, 2019
…Plugin (Lyrkan) This PR was merged into the master branch. Discussion ---------- Update various dependencies and remove the LoaderOptionsPlugin This PR updates various dependencies that were either really outdated or subject to security issues. Since most of those packages are listed in our dev dependencies it shouldn't have a big impact on most users, but the following changes could be an issue for some of them: * The `css-loader` was updated from `^1.0.0` to `^2.1.1` ([breaking changes](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#200-2018-12-07)) * The `resolve-url-loader` was updated from `^2.3.0` to `^3.0.1` ([breaking changes](https://github.com/bholloway/resolve-url-loader/tree/master/packages/resolve-url-loader#version-3), closes #428 and closes #534) * The minimum version of NodeJS was bumped from 6 to 8 (needed to update `zombie`, and v6's end-of-life happening in less than a month anyway) * The [`LoaderOptionsPlugin`](https://webpack.js.org/plugins/loader-options-plugin/) was removed since it should not be needed anymore and caused a *really annoying* bug when used with the latest version of the `resolve-url-loader` (see #428 (comment)) Commits ------- aeea89b Update various dependencies and remove the LoaderOptionsPlugin
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Apr 6, 2019
This PR was merged into the master branch. Discussion ---------- Update Encore and tweak some of its settings This PR: * Updates the version of Encore to `^0.26` * Updates the related bundle to `^1.4` * Fixes the imported font paths that were not working anymore due to [the recent `resolve-url-loader` update](symfony/webpack-encore#540) * Enables integrity hashes by default * Adds `core-js@3` and configures Babel properly so polyfills are automatically added to the resulting build * Disables file versioning when not in production mode (which prevented from using the dev-server) Commits ------- 8ee0df5 Update Encore and tweak some of its settings
Closed
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Update Encore and tweak some of its settings This PR: * Updates the version of Encore to `^0.26` * Updates the related bundle to `^1.4` * Fixes the imported font paths that were not working anymore due to [the recent `resolve-url-loader` update](symfony/webpack-encore#540) * Enables integrity hashes by default * Adds `core-js@3` and configures Babel properly so polyfills are automatically added to the resulting build * Disables file versioning when not in production mode (which prevented from using the dev-server) Commits ------- 8ee0df5 Update Encore and tweak some of its settings
mwhorse46
added a commit
to mwhorse46/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Update Encore and tweak some of its settings This PR: * Updates the version of Encore to `^0.26` * Updates the related bundle to `^1.4` * Fixes the imported font paths that were not working anymore due to [the recent `resolve-url-loader` update](symfony/webpack-encore#540) * Enables integrity hashes by default * Adds `core-js@3` and configures Babel properly so polyfills are automatically added to the resulting build * Disables file versioning when not in production mode (which prevented from using the dev-server) Commits ------- 8ee0df5 Update Encore and tweak some of its settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates various dependencies that were either really outdated or subject to security issues.
Since most of those packages are listed in our dev dependencies it shouldn't have a big impact on most users, but the following changes could be an issue for some of them:
css-loader
was updated from^1.0.0
to^2.1.1
(breaking changes)resolve-url-loader
was updated from^2.3.0
to^3.0.1
(breaking changes, closes resolve-url-loader magic behavior #428 and closes How to exclude dirs from sass loader? #534)zombie
, and v6's end-of-life happening in less than a month anyway)LoaderOptionsPlugin
was removed since it should not be needed anymore and caused a really annoying bug when used with the latest version of theresolve-url-loader
(see resolve-url-loader magic behavior #428 (comment))