Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify missing css file error message #940

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

RolfBabijn
Copy link
Contributor

@RolfBabijn RolfBabijn commented Feb 24, 2021

As a new user I came across a very confusing error message which took me way too long to debug. I was trying to set up the new webpack-encore configuration to use the twig-loader. I followed all the instructions, but I kept getting the following error:

./node_modules/twig/twig.js contains a reference to the file path.
This file can not be found, please check it for typos or update it if the file got moved.

Since "file path" is a very commonly used phrase, I did not realise that it meant that the file (or dependency) path was missing. Searching online also didn't help me out.

I'm not sure what the best solution is (or if it's an accepted edge case), but having it highlighted could save some new users a lot of time and frustration when starting out. I decided on simple quotes since that works regardless of colours are enabled in the terminal.

@RolfBabijn RolfBabijn force-pushed the fix/clarify-missing-css-error branch from c4565c3 to 2b1562a Compare February 24, 2021 12:36
@RolfBabijn
Copy link
Contributor Author

@stof: Thanks for the review. I've updated the code accordingly. Could you check the changes? I've left the discussion open for you to comment on or to resolve/close.

@weaverryan weaverryan force-pushed the fix/clarify-missing-css-error branch from fc4937d to 897c107 Compare March 1, 2021 01:09
@weaverryan
Copy link
Member

Wow, this is wonderful! Even I had to stare for a minute at the error message you received and check the code... I was also confused! Thank you so much for, at the very least, saving others the pain in the future. Cheers Rolf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants