Add option --forms-only to generate-admin command #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!$formsOnly) { | ||
| $generator->addBuilder(new ListBuilderAction()); | ||
| $generator->addBuilder(new ListBuilderTemplate()); | ||
| } | ||
| $generator->addBuilder(new FiltersBuilderType()); |
There was a problem hiding this comment.
@sescandell why generate filter forms?
tobias-93
force-pushed
the
master
branch
2 times, most recently
from
c787c50 to
60fecc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose to add the
--forms-onlyoption to thegenerate-admincommand.If set, only forms will be generated, and not controllers and views.
This is a kind of "improve process" for embed types (you had to manually remove all unnecessary generated files by hand)