Fixed the location of the SSL certificate on Windows #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that for Unix systems, I keep using the system certificates as they may be more uptodate than the Guzzle3 certificates |
Options should be merged with the existing configuration of the client instead of overwriting the whole config
|
I added another bug fix in a separate commit. I haven't submitted it separately as it is necessary for the Windows support to work, but I think it would be worth keeping the 2 separate commits when merging rather than squashing them |
|
Thanks for fixing this bug @stof. |
lyrixx
added a commit
that referenced
this pull request
Sep 5, 2014
This PR was merged into the 1.1.x-dev branch. Discussion ---------- Fixed the location of the SSL certificate on Windows Closes #34 The solution used here will work fine even when the tool is bundled as phar thanks to the Guzzle magic. However, people passing their own client will need to take care of making it SSL-capable themselves (which is an issue only for Windows, and maybe not at all on 5.6) Commits ------- 662e1eb Fixed the setting of the client options 98f24ab Fixed the location of the SSL certificate on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
The solution used here will work fine even when the tool is bundled as phar thanks to the Guzzle magic. However, people passing their own client will need to take care of making it SSL-capable themselves (which is an issue only for Windows, and maybe not at all on 5.6)