portalocker major release breaks ilock #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release of version 2.0 of portalocker https://pypi.org/project/portalocker/#history breaks iLock. A condition to use earlier versions of portalocker is necessary. Example exception caused by the portalocker release is available below: 2020-08-04 01:51:03,146 - Thread-7driver - ERROR: Unexpected Python Exception Occurred: Traceback (most recent call last): File "/home/pipelines/result_aggregation/driver.py", line 45, in <module> from package.app import * File "/home/pipelines/result_aggregation/package/app.py", line 8, in <module> from ilock import ILock File "/usr/bin/anaconda/lib/python2.7/site-packages/ilock/__init__.py", line 8, in <module> import portalocker File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/__init__.py", line 5, in <module> from . import utils File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/utils.py", line 290 def __init__(self, maximum: int, name: str = 'bounded_semaphore', ^ SyntaxError: invalid syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release of version 2.0 of portalocker https://pypi.org/project/portalocker/#history breaks iLock in python 2. A condition to use earlier versions of portalocker is necessary until version 2.0 is supported by ilock. Example exception caused by the portalocker release is available below:
2020-08-04 01:51:03,146 - Thread-7driver - ERROR: Unexpected Python Exception Occurred:
Traceback (most recent call last):
File "/home/pipelines/result_aggregation/driver.py", line 45, in
from package.app import *
File "/home/pipelines/result_aggregation/package/app.py", line 8, in
from ilock import ILock
File "/usr/bin/anaconda/lib/python2.7/site-packages/ilock/init.py", line 8, in
import portalocker
File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/init.py", line 5, in
from . import utils
File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/utils.py", line 290
def init(self, maximum: int, name: str = 'bounded_semaphore',
^
SyntaxError: invalid syntax