Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

Hide not run browser tests from docs #273

Merged

Conversation

JDawes-ScottLogic
Copy link
Collaborator

Tests that are not run for the browser are included in the documentation
for a method, showing as 0/x. This change is to only include tests for
the browser when we have actually run some tests.

Linked to #272

@ghost
Copy link

ghost commented Jul 19, 2017

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have you on file. In order for us to review and merge your code, please follow the link above and follow the instructions. If you have questions or believe you've received this message in error, don't hesitate to contact Aaron Williamson, our General Counsel and Director of Governance.

CLA has not been signed by users @JDawes-ScottLogic

Copy link
Collaborator

@BenLambertNcl BenLambertNcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that will look a lot nicer! Thanks!

@ghost
Copy link

ghost commented Jul 19, 2017

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have you on file. In order for us to review and merge your code, please follow the link above and follow the instructions. If you have questions or believe you've received this message in error, don't hesitate to contact Aaron Williamson, our General Counsel and Director of Governance.

CLA has not been signed by users @JDawes-ScottLogic

@ghost ghost added the cla-signed label Jul 20, 2017
Tests that are not run for the browser are included in the documentation
for a method, showing as 0/x. This change is to only include tests for
the browser when we have actually run some tests.
@ghost ghost added the cla-signed label Jul 20, 2017
@BenLambertNcl BenLambertNcl merged commit 09cdbce into symphonyoss:master Jul 20, 2017
@JDawes-ScottLogic JDawes-ScottLogic deleted the docs-no-browser-tests branch July 20, 2017 10:17
@maoo maoo mentioned this pull request Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants