Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect only natscontext package #5

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ripienaar
Copy link
Contributor

This adds a version of natscontext that supports only the parts needed to connect to nats and none of the management features the CLI needs, this is in order to keep the usage API and dependencies low

@ripienaar ripienaar marked this pull request as ready for review December 4, 2024 12:26
@ripienaar ripienaar changed the title Draft natscontext Add connect only natscontext package Dec 4, 2024
@piotrpio piotrpio self-requested a review December 4, 2024 12:29
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits.

natscontext/context.go Outdated Show resolved Hide resolved
natscontext/context.go Outdated Show resolved Hide resolved
natscontext/context.go Show resolved Hide resolved
natscontext/context.go Show resolved Hide resolved
This adds a version of natscontext that supports only the
parts needed to connect to nats and none of the management
features the CLI needs, this is in order to keep the usage
API and dependencies low

Signed-off-by: R.I.Pienaar <[email protected]>
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ripienaar ripienaar merged commit 2cd9577 into synadia-io:main Dec 6, 2024
4 checks passed
@ripienaar ripienaar deleted the natscontext branch December 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants