Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFQ] Listener Cancellation Fix #1760

Closed
trajan0x opened this issue Jan 7, 2024 · 2 comments
Closed

[RFQ] Listener Cancellation Fix #1760

trajan0x opened this issue Jan 7, 2024 · 2 comments

Comments

@trajan0x
Copy link
Contributor

trajan0x commented Jan 7, 2024

Workaround to be added and documented here prior to launch (#1650)

When an rpc returns an error in listener, the entire listener for that chain shuts off. This of course should not happen because

Image

Would recommend investigating and fixing through unit tests on listener. Scaffolding for this already exists, errors need only be mocked out

@trajan0x trajan0x added this to RFQ Jan 7, 2024
@trajan0x trajan0x converted this from a draft issue Jan 7, 2024
@trajan0x trajan0x changed the title [RFQ} Listener Cancellation Fix [RFQ] Listener Cancellation Fix Jan 7, 2024
This was referenced Jan 7, 2024
@trajan0x
Copy link
Contributor Author

trajan0x commented Jan 7, 2024

Investigating this now, you can see the dropoff here in doPoll requests to arbitrum:

image

The pod breaks at 10:13 and I reset as per @aureliusbtc at 10:23:

image

As you can see, omnirpc returns an error here:

image

Because this happens on block.number, we expect an error return here:

image

To debug this, I'm going to log pollInterval:

image

Okay, nevermind all that

I think if pollInterval is time.Millisecond (1,000) and we multiply by time.Second we get a lot of minutes. I'm not sure this explained why the thing stalled overnight, but it's worth a shot

image image

trajan0x added a commit that referenced this issue Jan 7, 2024
@trajan0x
Copy link
Contributor Author

trajan0x commented Jan 7, 2024

Fixed

@trajan0x trajan0x closed this as completed Jan 7, 2024
@github-project-automation github-project-automation bot moved this from Post Launch to Done in RFQ Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant