Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade sdk #1808

Merged
merged 1 commit into from
Jan 10, 2024
Merged

upgrade sdk #1808

merged 1 commit into from
Jan 10, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Jan 9, 2024

Description

Upgrade sdk w/ params from #1778

Summary by CodeRabbit

  • Refactor
    • Updated blockchain addresses for Optimism, Arbitrum, and Ethereum in network settings.

Copy link
Contributor

coderabbitai bot commented Jan 9, 2024

Walkthrough

The recent update reflects a change in the FAST_BRIDGE_EXCEPTION_MAP within the addresses.ts file, where the bridge addresses for the OPTIMISM, ARBITRUM, and ETH blockchain networks have been updated. This modification suggests an adjustment to how these chains handle fast bridge operations within the SDK router package.

Changes

File Path Change Summary
.../sdk-router/src/constants/addresses.ts Updated FAST_BRIDGE_EXCEPTION_MAP with new addresses for OPTIMISM, ARBITRUM, and ETH.

Poem

In the code's woven warren, a hop, skip, and jump,
Chains linked anew, with an expert's thump.
🌉 Bridges spanned with an adept tweak,
🐇 A rabbit's touch, for the tech we seek.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the size/m label Jan 9, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c857db1 and 15dbfc1.
Files ignored due to filter (1)
  • packages/sdk-router/src/abi/FastBridge.json
Files selected for processing (1)
  • packages/sdk-router/src/constants/addresses.ts (1 hunks)
Additional comments: 1
packages/sdk-router/src/constants/addresses.ts (1)
  • 64-66: Please confirm that the new addresses for OPTIMISM, ARBITRUM, and ETH in the FAST_BRIDGE_EXCEPTION_MAP are correct and have been properly communicated to all stakeholders. The format of the addresses appears to be standard Ethereum addresses, but it's crucial to ensure they are the intended ones for the upgrade.

Comment on lines 61 to 69
*/
const FAST_BRIDGE_ADDRESS = ''
const FAST_BRIDGE_EXCEPTION_MAP: AddressMap = {
[SupportedChainId.OPTIMISM]: '0x743fFbd0DbF88F6fCB7FaDf58fB641da93056EdF',
[SupportedChainId.ARBITRUM]: '0xA9EBFCb6DCD416FE975D5aB862717B329407f4F7',
[SupportedChainId.OPTIMISM]: '0x89fb287cc34c2878549a741f2c82d9c2e4657693',
[SupportedChainId.ARBITRUM]: '0x1a54fa31cbcad8c1cbc3a47dcd00864eac9ac2b0',
[SupportedChainId.ETH]: '0xc3c996af7f7a9245685722e73b6f18f3bb22db3d',
}

export const FAST_BRIDGE_ADDRESS_MAP: AddressMap = generateAddressMap(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [60-60]

The FAST_BRIDGE_ADDRESS is currently an empty string with a TODO comment to update it once FastBridge is deployed. If FastBridge has been deployed, this address should be updated to reflect the correct contract address.

@trajan0x trajan0x merged commit a3c12be into master Jan 10, 2024
31 of 33 checks passed
@trajan0x trajan0x deleted the fix/new-contracts branch January 10, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants