-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade sdk #1808
upgrade sdk #1808
Conversation
WalkthroughThe recent update reflects a change in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- packages/sdk-router/src/abi/FastBridge.json
Files selected for processing (1)
- packages/sdk-router/src/constants/addresses.ts (1 hunks)
Additional comments: 1
packages/sdk-router/src/constants/addresses.ts (1)
- 64-66: Please confirm that the new addresses for
OPTIMISM
,ARBITRUM
, andETH
in theFAST_BRIDGE_EXCEPTION_MAP
are correct and have been properly communicated to all stakeholders. The format of the addresses appears to be standard Ethereum addresses, but it's crucial to ensure they are the intended ones for the upgrade.
*/ | ||
const FAST_BRIDGE_ADDRESS = '' | ||
const FAST_BRIDGE_EXCEPTION_MAP: AddressMap = { | ||
[SupportedChainId.OPTIMISM]: '0x743fFbd0DbF88F6fCB7FaDf58fB641da93056EdF', | ||
[SupportedChainId.ARBITRUM]: '0xA9EBFCb6DCD416FE975D5aB862717B329407f4F7', | ||
[SupportedChainId.OPTIMISM]: '0x89fb287cc34c2878549a741f2c82d9c2e4657693', | ||
[SupportedChainId.ARBITRUM]: '0x1a54fa31cbcad8c1cbc3a47dcd00864eac9ac2b0', | ||
[SupportedChainId.ETH]: '0xc3c996af7f7a9245685722e73b6f18f3bb22db3d', | ||
} | ||
|
||
export const FAST_BRIDGE_ADDRESS_MAP: AddressMap = generateAddressMap( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [60-60]
The FAST_BRIDGE_ADDRESS
is currently an empty string with a TODO comment to update it once FastBridge is deployed. If FastBridge has been deployed, this address should be updated to reflect the correct contract address.
Description
Upgrade sdk w/ params from #1778
Summary by CodeRabbit