fix(relayer): relayer passes metric handler to price fetcher

[dwasse]

Summary by CodeRabbit

• Refactor
  • Enhanced the pricing component with improved monitoring integration to boost reliability and observability during price retrieval.

[coderabbitai]

Walkthrough

The update modifies the function call in the NewRelayer function to pass a metricHandler argument when invoking NewCoingeckoPriceFetcher. This change aligns with the updated function signature in the pricer package. No additional modifications to control flow, error handling, or other logic were observed.

Changes

Files	Change Summary
services/rfq/relayer/service/relayer.go	Updated the instantiation call to NewCoingeckoPriceFetcher by adding the metricHandler argument to match the new signature.

Sequence Diagram(s)

sequenceDiagram
    participant R as NewRelayer
    participant P as NewCoingeckoPriceFetcher
    participant M as metricHandler

    R->>P: Call NewCoingeckoPriceFetcher(metricHandler, timeout)
    Note over P: Processes call with enhanced metrics handling

Loading

Possibly related PRs

• Add tracing for coingecko price fetching #3514: Updates the NewCoingeckoPriceFetcher function signature and usage, closely aligning with the changes in this PR.

Suggested labels

go, size/xs, needs-go-generate-contrib/promexporter, needs-go-generate-services/rfq

Suggested reviewers

• aureliusbtc
• trajan0x

Poem

In a realm of code so bright,
A change was made with pure delight.
With metrics now in the mix,
I hopped along, quick as a fix.
ASCII hops, a joyful sight,
From your rabbit friend coding through the night!
🐰💻

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b299b5b and 250eed0.

📒 Files selected for processing (1)

• services/rfq/relayer/service/relayer.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Go Coverage (1.22.x, services/rfq)
• GitHub Check: Go Generate (Module Changes) (services/rfq)
• GitHub Check: Go Generate (Module Changes) (contrib/promexporter)
• GitHub Check: Go Generate (Module Changes) (contrib/opbot)

🔇 Additional comments (1)

services/rfq/relayer/service/relayer.go (1)

130-130: LGTM! Consistent with the codebase's metrics handling pattern.

The addition of the metricHandler parameter to NewCoingeckoPriceFetcher aligns with how metrics are handled throughout the codebase, where the metric handler is consistently passed to service initializations.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[parodime]

LGTM - TX

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.61203%. Comparing base (b299b5b) to head (250eed0).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
services/rfq/relayer/service/relayer.go	0.00000%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #3516         +/-   ##
===================================================
- Coverage   19.63579%   19.61203%   -0.02376%     
===================================================
  Files            145         145                 
  Lines          12136       12166         +30     
===================================================
+ Hits            2383        2386          +3     
- Misses          9479        9504         +25     
- Partials         274         276          +2     

Flag	Coverage Δ
opbot	0.18282% <ø> (ø)
promexporter	6.81642% <ø> (ø)
rfq	24.85380% <0.00000%> (-0.04843%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cloudflare-workers-and-pages]

Deploying sanguine-fe with    Cloudflare Pages

Latest commit:	250eed0
Status:	✅  Deploy successful!
Preview URL:	https://b6a5e793.sanguine-fe.pages.dev
Branch Preview URL:	https://fix-cg-trace.sanguine-fe.pages.dev

View logs