-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update quoter v2 config #320
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Pull Request Test Coverage Report for Build 8285687609Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (5)
deployments/canto/DefaultPoolCalc.json
is excluded by:!**/*.json
deployments/canto/SwapQuoterV2.json
is excluded by:!**/*.json
script/configs/SwapQuoterV2.ignored.json
is excluded by:!**/*.json
script/configs/avalanche/SwapQuoterV2.dc.json
is excluded by:!**/*.json
script/configs/canto/SwapQuoterV2.dc.json
is excluded by:!**/*.json
Files selected for processing (1)
- script/router/quoter/SaveConfigQuoterV2.s.sol (1 hunks)
Additional comments: 2
script/router/quoter/SaveConfigQuoterV2.s.sol (2)
- 49-54: The refactoring of the
loadIgnoredPools
function to use a newmarkIgnoredPools
function for handling ignored pools is a good improvement. It separates concerns and makes the code more modular. However, ensure that theignoredJson
structure and thevm.keyExists
method are robust enough to handle potential edge cases or malformed JSON data.- 60-69: The implementation of the
markIgnoredPools
function is clear and straightforward. Using thetryGetDeploymentAddress
method to resolve pool addresses from names and then marking them as ignored if they are not the zero address is a good approach. However, consider adding error handling or logging for cases wheretryGetDeploymentAddress
fails to find an address for a given pool name, as this could indicate a configuration issue.
Description
Also includes the artifacts for SwapQuoterV2 on Canto which was deployed some time ago, but never pushed 😮💨
Checklist
Summary by CodeRabbit
SaveConfigQuoterV2
contract, allowing for more flexible configurations.