Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report card issues #124

Closed
synfinatic opened this issue Nov 13, 2021 · 3 comments
Closed

Fix report card issues #124

synfinatic opened this issue Nov 13, 2021 · 3 comments
Assignees
@synfinatic
Labels
blocked Blocked on something else enhancement New feature or request
Milestone
1.3.0

Comments

@synfinatic
Copy link
Owner

https://goreportcard.com/report/github.com/synfinatic/aws-sso-cli
@synfinatic synfinatic added this to the 1.2.4 milestone Nov 13, 2021
@synfinatic synfinatic self-assigned this Nov 13, 2021
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
add and improve code report card
5863458 
 * Improve code quality
 * Add report card
 * Add golangci-lint to github workflows

Refs: #124
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
add and improve code report card
2ded0ab 
 * Improve code quality
 * Add report card
 * Add golangci-lint to github workflows

Refs: #124
@synfinatic synfinatic mentioned this issue Nov 13, 2021
Merged
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
add and improve code report card
1ff05e7 
 * Improve code quality
 * Add report card
 * Add golangci-lint to github workflows

Refs: #124
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
Fix more golint errors
4ed4767 
add `lint` make target

Refs: #124
@synfinatic synfinatic mentioned this issue Nov 13, 2021
Merged
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
Fix more golint errors
14e9b94 
add `lint` make target

Refs: #124
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
Fix more golint errors
d0364ca 
add `lint` make target

Refs: #124
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
Fix more golint errors
6afa927 
add `lint` make target

Refs: #124
synfinatic added a commit that referenced this issue Nov 13, 2021
@synfinatic
Fix more golint errors
715c12a 
 * add `lint` make target
 * fix workflow for golangci-lint
 * fix more golangci-lint errors

Refs: #124
@synfinatic
Copy link
Owner Author

so the issues are fixed but the report card is still showing out of date results? have tried forcing a re-check but it seems to be using cached results. need to check again in 24hrs

@synfinatic
Copy link
Owner Author

Looks related to: gojp/goreportcard#357

@synfinatic synfinatic added blocked Blocked on something else enhancement New feature or request labels Nov 14, 2021
@synfinatic
Copy link
Owner Author

Looks like this should auto resolve itself once 1.2.4 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synfinatic synfinatic

Labels
blocked Blocked on something else enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@synfinatic