Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing --url-action & update main args #136

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

synfinatic
Copy link
Owner

  • Fix error processing empty --url-action and --browser
  • No longer print URL when sending to browser or clipboard
  • Move defaults from DEFAULT_CONFIG to CLI struct

Fixes: #133

 * Fix error processing empty --url-action and --browser
 * No longer print URL when sending to browser or clipboard
 * Move defaults from DEFAULT_CONFIG to CLI struct

Fixes: #133
@codecov-commenter
Copy link

Codecov Report

Merging #136 (eb25fd9) into main (7df244c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   37.81%   37.81%           
=======================================
  Files           7        7           
  Lines        1169     1169           
=======================================
  Hits          442      442           
  Misses        692      692           
  Partials       35       35           
Impacted Files Coverage Δ
sso/settings.go 53.07% <ø> (ø)
utils/utils.go 41.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df244c...eb25fd9. Read the comment docs.

@synfinatic synfinatic merged commit 7000e59 into main Nov 16, 2021
@synfinatic synfinatic deleted the fix-empty-defaults branch November 16, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown --url-action option
2 participants