Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how we manage the AWS_DEFAULT_REGION #153

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Conversation

synfinatic
Copy link
Owner

  • Remove --region from exec & eval commands
  • Add --no-region to exec & eval commands
  • Never overwrite/clear the AWS_DEFAULT_REGION set by the user

Fixes: #152

 - Remove --region from exec & eval commands
 - Add --no-region to exec & eval commands
 - Never overwrite/clear the AWS_DEFAULT_REGION set by the user

Fixes: #152
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #153 (b96dc6a) into main (570b7b7) will increase coverage by 1.74%.
The diff coverage is 53.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   37.68%   39.43%   +1.74%     
==========================================
  Files           7        7              
  Lines        1186     1202      +16     
==========================================
+ Hits          447      474      +27     
+ Misses        700      692       -8     
+ Partials       39       36       -3     
Impacted Files Coverage Δ
sso/settings.go 60.46% <53.19%> (+7.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570b7b7...b96dc6a. Read the comment docs.

@synfinatic synfinatic merged commit 9758cec into main Nov 20, 2021
@synfinatic synfinatic deleted the default-region branch November 20, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More closely emulate profiles in ~/.aws/config for AWS_DEFAULT_REGION
1 participant