Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve config diff and write file #230

Merged
merged 1 commit into from
Jan 5, 2022
Merged

improve config diff and write file #230

merged 1 commit into from
Jan 5, 2022

Conversation

synfinatic
Copy link
Owner

  • Fix diffing across multiple runs
  • Consistent ordering based on SSO instance & ARN
  • Now updates the config file

Refs: #157

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #230 (e3561e4) into main (796d070) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   43.47%   43.47%           
=======================================
  Files          11       11           
  Lines        1702     1702           
=======================================
  Hits          740      740           
  Misses        898      898           
  Partials       64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796d070...e3561e4. Read the comment docs.

 * Fix diffing across multiple runs
 * Consistent ordering based on SSO instance & ARN
 * Now updates the config file

Refs: #157
@synfinatic synfinatic merged commit ff4cf2d into main Jan 5, 2022
@synfinatic synfinatic deleted the config3 branch January 5, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant