console command now supports $AWS_PROFILE #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 43.47% 43.86% +0.39%
==========================================
Files 11 11
Lines 1702 1721 +19
==========================================
+ Hits 740 755 +15
- Misses 898 902 +4
Partials 64 64
Continue to review full report at Codecov.
|
synfinatic
force-pushed
the
console-profile
branch
3 times, most recently
from
37d2ea4 to
76228fa
Compare
After all other existing checks, look to see if $AWS_PROFILE is set and if so, use those credentials to open the console with. Since not all profiles are necesssarily AWS SSO profiles, we will try using the Go SDK if necessary to load our credentials instead of the creds we have cached. Fixes: #234
synfinatic
force-pushed
the
console-profile
branch
from
76228fa to
68d4e0d
Compare
|
I even tested it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all other existing checks, look to see if $AWS_PROFILE
is set and if so, use those credentials to open the console with.
Since not all profiles are necesssarily AWS SSO profiles, we will
try using the Go SDK if necessary to load our credentials instead
of the creds we have cached.
Fixes: #234