Allow sorting of roles via an arbitrary field #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 77.79% 77.89% +0.10%
==========================================
Files 24 24
Lines 2756 2782 +26
==========================================
+ Hits 2144 2167 +23
- Misses 543 545 +2
- Partials 69 70 +1
Continue to review full report in Codecov by Sentry.
|
synfinatic
force-pushed
the
list-sorting
branch
2 times, most recently
from
ba37f6f to
9fdbdf3
Compare
Add `--sort` and `--reverse` to the `list` command to enable sorting by any available field and reverse sorting. Sorting always happens alphabetically and is case-sensitive. AccountIds are also now always presented with leading zeros as appropriate now. Improve unit tests for AccountId's with a leading zero Fixes #466
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--sortand--reverseto thelistcommand to enable sorting by any available field and reverse sorting. Sorting always happens alphabetically and is case-sensitive.AccountIds are also now always presented with leading zeros as appropriate now.
Fixes #466