Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CacheRefresh config option #655

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Remove CacheRefresh config option #655

merged 1 commit into from
Oct 29, 2023

Conversation

synfinatic
Copy link
Owner

No longer auto-refresh the cache. Users should
manually update it via aws-sso cache

Refs: #610

No longer auto-refresh the cache.  Users should
manually update it via `aws-sso cache`

Refs: #610
@synfinatic synfinatic added this to the 2.0.0 milestone Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #655 (9a3066e) into v2 (cb7c2c1) will increase coverage by 0.04%.
Report is 2 commits behind head on v2.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #655      +/-   ##
==========================================
+ Coverage   82.83%   82.87%   +0.04%     
==========================================
  Files          35       35              
  Lines        3268     3252      -16     
==========================================
- Hits         2707     2695      -12     
+ Misses        494      490       -4     
  Partials       67       67              
Files Coverage Δ
sso/cache.go 50.00% <ø> (-0.93%) ⬇️
sso/settings.go 75.96% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32af36...9a3066e. Read the comment docs.

@synfinatic synfinatic merged commit 253e5b8 into v2 Oct 29, 2023
@synfinatic synfinatic deleted the remove-cacherefresh branch October 29, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant