Merge pull request #14 from synnada-ai/record-batch-flags

Move Nullability Converter Into Schema Utils
synnada-ai · Nov 27, 2024 · 0754d75 · 0754d75
2 parents 5823472 + 97347c0
commit 0754d75
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/arrow-array/src/record_batch.rs b/arrow-array/src/record_batch.rs
@@ -656,21 +656,6 @@ impl RecordBatch {
             .sum()
     }
 
-    /// THIS METHOD IS ARAS ONLY
-    ///
-    /// Converts the fields of the batch to nullable.
-    pub fn make_fields_nullable(&mut self) {
-        let fields = self
-            .schema()
-            .fields()
-            .iter()
-            .map(|field| field.as_ref().clone().with_nullable(true)).collect::<Vec<_>>();
-        self.schema = Arc::new(Schema::new_with_metadata(
-            fields,
-            self.schema().metadata().clone(),
-        ));
-    }
-
     /// THIS METHOD IS ARAS ONLY
     ///
     /// Gets the metadata_flags of RecordBatch

diff --git a/arrow-schema/src/schema.rs b/arrow-schema/src/schema.rs
@@ -461,6 +461,17 @@ impl Schema {
     pub fn remove(&mut self, index: usize) -> FieldRef {
         self.fields.remove(index)
     }
+
+    /// THIS METHOD IS ARAS ONLY
+    ///
+    /// Converts the fields of the batch to nullable.
+    pub fn make_fields_nullable(&mut self) {
+        let fields = self
+            .fields
+            .iter()
+            .map(|field| field.as_ref().clone().with_nullable(true));
+        self.fields = Fields::from_iter(fields);
+    }
 }
 
 impl fmt::Display for Schema {