Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bfloat16 support #136

Merged
merged 13 commits into from
Jan 20, 2025

Conversation

aturker-synnada
Copy link
Collaborator

Description

Closes #133.

What is Changed

Include the changes introduced in this PR.

  • Backends now supports bfloat16.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

@aturker-synnada aturker-synnada force-pushed the bfloat16_support branch 21 times, most recently from 9ef4044 to 7620a84 Compare January 3, 2025 14:34
@aturker-synnada aturker-synnada force-pushed the bfloat16_support branch 12 times, most recently from 191a38d to 4127adb Compare January 6, 2025 14:17
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (d65d013) to head (f214de0).

Files with missing lines Patch % Lines
mithril/backends/backend.py 83.33% 1 Missing ⚠️
...hril/backends/with_autograd/jax_backend/backend.py 92.30% 1 Missing ⚠️
...hril/backends/with_autograd/mlx_backend/backend.py 91.66% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   88.81%   88.85%   +0.03%     
==========================================
  Files          61       61              
  Lines       15421    15474      +53     
==========================================
+ Hits        13696    13749      +53     
  Misses       1725     1725              
Files with missing lines Coverage Δ
mithril/__init__.py 77.77% <ø> (ø)
mithril/backends/utils.py 90.90% <100.00%> (+15.90%) ⬆️
...ithril/backends/with_autograd/jax_backend/utils.py 71.02% <100.00%> (+0.50%) ⬆️
...ithril/backends/with_autograd/mlx_backend/utils.py 61.49% <100.00%> (+0.73%) ⬆️
...il/backends/with_autograd/torch_backend/backend.py 92.55% <100.00%> (+0.13%) ⬆️
...hril/backends/with_autograd/torch_backend/utils.py 81.34% <100.00%> (+0.16%) ⬆️
.../backends/with_manualgrad/numpy_backend/backend.py 88.77% <100.00%> (+0.12%) ⬆️
...il/backends/with_manualgrad/numpy_backend/utils.py 74.85% <100.00%> (+0.44%) ⬆️
mithril/core.py 86.95% <100.00%> (+0.59%) ⬆️
mithril/backends/backend.py 63.95% <83.33%> (ø)
... and 2 more

tests/scripts/test_all_models.py Outdated Show resolved Hide resolved
tests/scripts/test_all_models.py Outdated Show resolved Hide resolved
mithril/backends/with_autograd/jax_backend/backend.py Outdated Show resolved Hide resolved
tests/scripts/test_all_models.py Show resolved Hide resolved
tests/scripts/test_all_models.py Outdated Show resolved Hide resolved
@kberat-synnada kberat-synnada merged commit 2d15221 into synnada-ai:main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for bfloat16
3 participants