Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update suggestions #670

Merged
merged 6 commits into from
Nov 9, 2022
Merged

fix(ui): update suggestions #670

merged 6 commits into from
Nov 9, 2022

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 8, 2022

Changes

  • simplify todos
  • adds a workaround for <Dialog />s getting stuck on iOS

Notes

  • initialize state with a simple array of all todos
  • if user dismisses a todo, remove the item from the state
  • if user completes a todo, remove the item from the state
  • predefined todos are added on user action (lightningSettingUp)
  • depending on other state, decide what to do when user clicks todo card

The workaround for the Dialog will issue a warning but it works. Will be removed as soon as the upstream issue gets fixed or after we upgrade react-native which enables us to swap the Dialog for the native Alert.

@pwltr pwltr requested a review from coreyphillips November 8, 2022 14:48
@pwltr pwltr force-pushed the fix/reset-suggestions branch from 4ed2380 to b44a912 Compare November 8, 2022 15:00
@pwltr pwltr merged commit cf7be9c into master Nov 9, 2022
@pwltr pwltr deleted the fix/reset-suggestions branch November 9, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants