Change footnote order #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arobase-che
added a commit
to arobase-che/zmarkdown
that referenced
this pull request
Jul 24, 2019
**This commit only convert new identifiers to string.** Identifiers used to be strings but in the previous version of this plugin, identifiers were converted to numbers. Now the type is preserved. Adapt the plugin to the commit of mdast-util-to-hast#fd38c454 See the issue: syntax-tree/mdast-util-to-hast#32 It updates the order of footnotes to a more coherent one. But identifiers no longer allowed to be number.
arobase-che
added a commit
to arobase-che/zmarkdown
that referenced
this pull request
Jul 24, 2019
Since : - syntax-tree/mdast-util-to-hast#32 - khttps://github.com/syntax-tree/mdast-util-to-hast/pull/15
arobase-che
added a commit
to arobase-che/zmarkdown
that referenced
this pull request
Jul 24, 2019
Adapt the code to : syntax-tree/mdast-util-to-hast#32
wooorm
added
⛵️ status/released
🗄 area/interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the footer (if footnote definitions were found) showed all footnote definitions, in definition order. Even footnote definitions with the same identifier were transformed to multiple definitions.
remarkjs/remark-rehype#11 shows that definition order does not make sense if inline footnotes (
[^Some text]) are used in combination with footnote references ([^id]) and footnote definitions ([^id]: Some text).Investigating this, I came to the conclusion that it also does not make sense to output all definitions, whether they are used (or even duplicate) or not.
Instead, it makes sense to track the order in which footnotes are used (first), and only output a definition for the used inline footnotes / footnote references, in the order they were used. This is in line with how link definitions are used as well.
/cc @CxRes
Closes remarkjs/remark-rehype#11.