Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Streams integration: change from .wait() to .ready #83

Closed
domenic opened this issue Jan 27, 2015 · 5 comments
Closed

Streams integration: change from .wait() to .ready #83

domenic opened this issue Jan 27, 2015 · 5 comments

Comments

@domenic
Copy link
Contributor

domenic commented Jan 27, 2015

I did a scan and .wait() is only used in notes and in examples so this is pretty minor. But in whatwg/streams#243 we changed from a side-effecting .wait() to a passive .ready in the public API.

@ClaesNilsson
Copy link
Contributor

Ok, thanks for spotting this Domenic. I'll replace .wait() with .ready in the examples and comments. Furthermore I see in whatwg/streams#245 that .ready is fulfill-only. So in the examples in the TCP and UDP Socket API specification errors must be handled in another way than with a promise reject function for .ready. I guess that I just can remove the promise reject handling and rely on mySocket.closed... handling to detect for example situations like loss of network contact.

@domenic
Copy link
Contributor Author

domenic commented Jan 28, 2015

Oh yeah, sorry for not noticing that too.

I guess that I just can remove the promise reject handling and rely on mySocket.closed... handling to detect for example situations like loss of network contact.

That was exactly the reasoning :)

@ClaesNilsson
Copy link
Contributor

I fill that and make a PR.

@ClaesNilsson
Copy link
Contributor

Looks ok? #84

@ClaesNilsson
Copy link
Contributor

Closed with #84

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants